-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add XPath support for namespace-uri() condition and attribute elements #4287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evie-lau
changed the title
Add XPath support for namespace-uri() condition
Add XPath support for namespace-uri() condition and attribute elements
Jun 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- rewrite-core/src/main/java/org/openrewrite/internal/lang/NullFields.java
- lines 36-36
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- rewrite-core/src/main/java/org/openrewrite/internal/lang/NullFields.java
- lines 36-36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Add support for
namespace-uri()
conditions in XPathMatcher, along with testsAdd attribute match support in XPathMatcher (
/@attributeName
)Update XPath splitter to handle URLs
What's your motivation?
Be able to use namespace filters in XPathMatcher
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
@sambsnyd @timtebeek
FYI: @ammachado
Have you considered any alternatives or workarounds?
Any additional context
Unsure about the addition of the new Interface
Namespaced
(or its naming). Just wanted to be able to run one of my methods on bothXml.Tag
andXml.Attribute
objects.Checklist